This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Enable shrink columns option in Product Collection by default #11821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: enhancement
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
13 tasks
albarin
approved these changes
Nov 20, 2023
… block, not Product Collection
|
There's related PR that preserves the "Shrink columns to fit" value when switching views #11905 |
kmanijak
deleted the
add/enable-shrink-column-in-product-collection-by-default
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable "Shrink columns to fit" in Product Collection by default.
Why
We agreed this feature is expected and valuable so we enable it by default for newly added Product Collection blocks. It won't influence the existing Product Collection blocks.
The change was also applied to couple of patterns:
It was NOT introduced to some others like "Product Collection X Columns". I assumed the title is explicit about the number of columns and that should be fixed. I'm open to feedback though!
In addition a hardcoded
queryIdwas removed from Related Products template (https://github.com/woocommerce/woocommerce-blocks/pull/11821/files#diff-d534fc0a912e2d40a2c9fc9d5de4b34fe0bf06dd6eb50527e6280432a2ed0870R12) as it should be generated dynamically so it's unique. More details and potential consequences available in PR that addressed that for other patterns: #11290.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
To be included in testing notes:
Case 1: Default Product Collection
Case 2: Patterns
Stackview enabled by default and then "Shrink columns to fit" is not available. Change the view fromStacktoGridBelow test is for development team exclusively:
trunk, add Product Collection block"shrinkColumns":false"- this step is to mimic the case when someone added the block before the option was even introduceadd/enable-shrink-column-in-product-collection-by-defaultsetAttributefunctionScreenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog