This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Ensure that incompatible notices are displayed in Safari #11736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: bug
woocommercebot
requested review from
a team and
mikejolley
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -20 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
ralucaStan
reviewed
Nov 10, 2023
| @@ -18,11 +18,11 @@ | |||
| width: 24px; | |||
| height: 24px; | |||
| margin-right: 6px; | |||
| min-width: max-content; | |||
| min-width: 24px; // Ensure that notice is visible in Safari. See https://github.com/woocommerce/woocommerce-blocks/issues/11734 | |||
There was a problem hiding this comment.
considering this is min width and the settings editor is a defined with it's ok to leave in this fixed value
ralucaStan
approved these changes
Nov 10, 2023
mikejolley
approved these changes
Nov 10, 2023
tarhi-saad
force-pushed
the
fix/11734-display-incompatibility-extension-notice-in-safari
branch
from
947cce7
to
b64d29f
Compare
tarhi-saad
force-pushed
the
fix/11734-display-incompatibility-extension-notice-in-safari
branch
from
b64d29f
to
5c1d48b
Compare
tarhi-saad
deleted the
fix/11734-display-incompatibility-extension-notice-in-safari
branch
tarhi-saad
pushed a commit
that referenced
this pull request
Nov 10, 2023
nielslange
added a commit
that referenced
this pull request
Nov 13, 2023
* Empty commit for release pull request * Empty commit for release pull request * Empty commit for release pull request * Empty commit for release pull request * Update Jetpack WooCommerce Analytics module integration to check for changed template names (#11707) * Bump versions to 11.4.6 * Add testing notes * Update testing zip * Skip template related E2E tests (#11700) * Empty commit for release pull request * Fix address block invalidations in the editor and address card display in Firefox (#11714) * Add checks to see if getCartData finished before rendering address * Prevent block error due to excessive updates of customValidation * Do not condense address in admin and handle phone field * Add missing showPhoneField for billing --------- Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> * Add changelog in "readme.txt" * Run change version npm script * Add testing notes * Empty commit for release pull request * Add changelog in "readme.txt" * Add version numbers * Ensure that incompatible notices are displayed in Safari. (#11736) * Add the testing docs * Update testing notes title of 11.4.8 --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Thomas Roberts <thomas.roberts@automattic.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Niels Lange <info@nielslange.de>
opr
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11734
min-width: max-content;tomin-width: 24px;to ensure that incompatible notices are displayed in Safari.margin: 0 0 1em 1.5em;tomargin: 0 0 1em 1.2em;to ensure that line-breaks, in incompatible extension names, kick in later when using Firefox.Why
An external contributor reported that the incompatible extension notices are not displayed when using Safari. It turned out that the issue was based on a
min-widthsetting, that wasn't correctly interpreted by Safari. This PR fixes this issue, while ensuring that incompatible extension notices remain visible in other browsers.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog