This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[CYS] Reduce the number of times the patterns dictionary is accessed #11733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
albarin
requested review from
nefeline,
gigitux and
tjcafferkey
and removed request for
gigitux
gigitux
approved these changes
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR reduces the number of times the pattern dictionary is accessed: before, each pattern was calling the
get_patterns_dictionaryfunction at least once (twice for pattern with images). With this PR, we call the function just once, when registering the patterns, and we pass to them the dictionary.Why
Since the pattern registration happens in the
inithook, all these calls are done for each page load, so this change will reduce it.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog