This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move CheckboxControl to components package and leave alias in checkout package
#11662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
category: extensibility
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
packages/components/checkbox-control/index.tsx
|
|
Size Change: +154 B (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
opr
force-pushed
the
move/checkbox-control
branch
2 times, most recently
from
c8b939f
to
5dc7f85
Compare
|
Just pointing out that you've got a neat changelog entry (that I definitely didn't copy for another PR), but you've got the |
opr
removed
the
skip-changelog
opr
force-pushed
the
move/checkbox-control
branch
from
5dc7f85
to
948c829
Compare
wavvves
approved these changes
Nov 21, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move
CheckboxControlto components package and leave alias in checkout package.Why
Doesn't make sense to have external components in multiple locations in the codebase. An alias is left in the checkout package for backward compatibility.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Internal Developer Testing (do not include in the notes)
wc.blocksComponentswc.blocksCheckout.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog