This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Change the "chessboard" pattern structure to improve mobile view #11545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
tjcafferkey
approved these changes
Nov 2, 2023
|
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
|
It is a shame we can't reorder elements on small device sizes to be [image / text / image / text] rather than [image / text / text / image] but that is a limitation of blocks at the moment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the "Hero Product Chessboard" pattern structure. Also, adds length limits to the AI prompts.
Why
To improve how the pattern looks in smaller screen sizes.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Hero Product Chessboardpattern.(3. For devs only: pay special attention to the code, there should not be any hard-coded strings that are not translatable).
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog