This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add checkout-header template to the correct area in site editor #11528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this class is refactored, move title, description, a...When this class is refactored, move title, description, and area definition to the template classes (CheckoutHeaderTemplate, MiniCartTemplate, etc).
woocommerce-blocks/src/Utils/BlockTemplateUtils.php Lines 227 to 238 in 574baae 🚀 This comment was generated by the automations bot based on a
|
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Nov 1, 2023
| @@ -223,8 +224,16 @@ public static function build_template_result_from_file( $template_file, $templat | |||
| $template->area = 'uncategorized'; | |||
|
|
|||
| // Force the Mini-Cart template part to be in the Mini-Cart template part area. | |||
| if ( 'wp_template_part' === $template_type && 'mini-cart' === $template_file->slug ) { | |||
| $template->area = 'mini-cart'; | |||
| // @todo When this class is refactored, move title, description, and area definition to the template classes (CheckoutHeaderTemplate, MiniCartTemplate, etc). | |||
There was a problem hiding this comment.
Just wondering if we can refactor the code into a function, allowing us to reuse it for other templates.
function getTemplateAreaBySlug($slug) {
$areas = [
'mini-cart' => 'mini-cart',
'checkout-header' => 'header'
];
return $areas[$slug] ?? 'uncategorized';
}
if ('wp_template_part' === $template_type) {
$template->area = getTemplateAreaBySlug($template_file->slug);
}There was a problem hiding this comment.
Yes, but origami are going to be refactoring all of this soon so best we don't touch it at this point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the checkout-header template part under the "header" area in the site editor.
Why
Organisation.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog