-
Notifications
You must be signed in to change notification settings - Fork 218
Product Collection: Fix the PHP Warning after migrating from Products (Beta) #11494
Product Collection: Fix the PHP Warning after migrating from Products (Beta) #11494
Conversation
…s' warning after migrating from Products (Beta)
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
Hey @danieldudzic, I'm not seeing the warnings anymore but the editor and the front end look different 👇
|
Right, but this is also happening in the Seems like the migration in broken. But that's a separate issue. I'll create a new, separate issue for that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I have now opened a separate issue for the migration issue: woocommerce/woocommerce#42153 |
What
Fixes #11437
Why
This PR fixes the PHP warning present after utilizing the
Upgrade to Product Collection
link inProducts (Beta)
block:Warning: Undefined array key "woocommerceAttributes" in /srv/users/user7f63c11d/apps/user7f63c11d/public/wp-content/plugins/woocommerce-gutenberg-products-block/src/BlockTypes/ProductCollection.php on line 313
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Large Image Product Gallery
pattern.Upgrade to Product Collection
option in the sidebar and save the page.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog