This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Essential Header Dark pattern: Fix color contrast issues in TT4 #11480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.53 MB ℹ️ View Unchanged
|
thealexandrelara
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks good! I just tested it, and the contrast for the header and its links are correct ✅
I think it would be a good idea to add a step to the testing instructions explaining how to make the dropdown links appear (I achieved this by setting one of the pages as the parent page for the others.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11297
Why
This PR fixes the color contrast issues in the Essential Header Dark pattern with Twenty Twenty-Four.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Navigationblock make sure you have some nested items. (Dropdown menu)Screenshots or screencast
Before
After
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog