This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Store Customization] Fix pattern spacing in homepage template 1 #11268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the top/bottom paddings, adds margins to the bottom of each pattern
albarin
added
type: enhancement
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
woocommercebot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
Size Change: 0 B Total Size: 1.48 MB ℹ️ View Unchanged
|
albarin
added
type: bug
dinhtungdu
reviewed
Oct 17, 2023
Thanks for your review @dinhtungdu, in this case, we need to achieve consistency with the pattern spacing across themes, so I think hardcoding margins is the only way. I tried using |
tjcafferkey
approved these changes
Oct 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes the top/bottom paddings, and adds margins to the bottom of each of these patterns:
Part of #11252
Why
To match the designs and ensure consistency between themes.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
80pxbetween all of them.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog