This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add Local Pickup event and Cart/Checkout page views events #11225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
force-pushed
the
feature/jetpack-tracking
branch
from
38d51ec
to
e6c9e8c
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/extensions/jetpack/woocommerce-analytics/index.ts
|
|
Size Change: +769 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
senadir
force-pushed
the
feature/jetpack-tracking
branch
from
e6c9e8c
to
bb43672
Compare
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
senadir
added
block: cart
nielslange
reviewed
Oct 20, 2023
There was a problem hiding this comment.
Thanks for working on this, @senadir. I've gone through the functionality of this PR and everything seems to be working well. I've given the code a look, but I'll leave the detailed code review for @opr.
Just a couple of suggestions for consideration:
- For better organization, perhaps we could consider placing the TS interfaces in
assets/js/extensions/jetpack/woocommerce-analytics/index.tseither at the top or directly above their respective functions. - For readability, it might be helpful to maintain consistent line breaks in the touched files. Adding a few more might enhance clarity.
That said, the suggestions are my personal thoughts, while reviewing the code. Feel free to ignore them and ⛴️ the PR as it is if @opr gives the green light.
opr
approved these changes
Oct 20, 2023
opr
added
the
type: task
senadir
force-pushed
the
feature/jetpack-tracking
branch
from
bb43672
to
d858229
Compare
…#10815) Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com>
senadir
force-pushed
the
feature/jetpack-tracking
branch
from
5a08178
to
7fa26c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the feature branch PR that contained the work we did to track Cart/Checkout pages, see PRs:
#10841
#10825
#10815
Testing steps
You will need a live, tracking enabled, Jetpack connected website to test the following PRs.
Local Pickup
Page view
Changelog