This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery pattern: Use the Product Collection block #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o use the Product Collections block
tjcafferkey
added
type: bug
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
tjcafferkey
requested review from
albarin and
nefeline
and removed request for
roykho
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +20 B (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
albarin
suggested changes
Oct 10, 2023
tjcafferkey
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the
woocommerce-blocks/product-query-product-galleryto use the Product Collection pattern and removes the text which was produced by the Post excerpt block.Fixes #11185
Why
This pattern is being used in the CYS project and was showing content editor side which wasn't representative of the frontend, produced by the Post excerpt block.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
woocommerce-blocks/product-query-product-gallerypattern.Add "remove more" link textdoesn't appear in the editor above the price.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog