This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Condensed Address Form Implementation #11167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
nielslange
and removed request for
a team
7 tasks
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
mikejolley
added
type: enhancement
|
Size Change: +10.9 kB (+1%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
nielslange
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Thanks for working on this, @mikejolley. I've successfully tested this PR.
I'm pre-approving this PR, but was wondering if we need to display the phone number. For example, in my Amazon profile, I only see the address data itself, but not the phone number. Not displaying the phone number, would make the condensed address form yet a bit more condensed.
Example with a long Dutch address:
Example with a short Dutch address:
roykho
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduces condensed address components on the checkout for returning shoppers.
Fixes #9787
Why
Removes long forms when address data already exists, whilst allowing easy editing during checkout. Tests have been updated to click the "edit" button.
Justification and designs can be found in #9787 (comment)
Testing Instructions
As a logged out guest customer
As a logged in user who has checked out before (has an address)
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog