This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Store Customization > Update aspect ratio, icons and default text for the Social: Follow us on social media pattern #11161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e assigned to it and update the content assignment.
…thin the dictionary.
nefeline
added
type: enhancement
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
|
@nefeline It's working fine when testing on my local store, but in the JN site from the testing steps I'm getting different results in the editor and the front end, is the plugin updated there? 🤔
|
…image-is-displayed-on-just-arrived-pattern
…ved-pattern' into add/aspect-ratio-to-follow-us-on-social-media-pattern
@albarin my bad! I had to switch branches and that automatically affected the JN install because of the auto-deploy tool I have enabled locally: should be a-ok now ;) |
albarin
approved these changes
Oct 6, 2023
Base automatically changed from
fix/ensure-ai-generated-image-is-displayed-on-just-arrived-pattern
to
trunk
October 6, 2023 11:17
nefeline
deleted the
add/aspect-ratio-to-follow-us-on-social-media-pattern
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
This change is necessary to ensure the design for this pattern matches the expected
Figma: Mrk6SERPZ4KrFHSjM0a8TK-fi-5716_46688
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog