This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Pattern: fetch product id on the JS side #11138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
node_modules/@woocommerce/data/build-types/countries/index.d.ts
node_modules/@woocommerce/data/build-types/export/index.d.ts node_modules/@woocommerce/data/build-types/import/index.d.ts node_modules/@woocommerce/data/build-types/items/index.d.ts node_modules/@woocommerce/data/build-types/onboarding/index.d.ts node_modules/@woocommerce/data/build-types/options/index.d.ts node_modules/@woocommerce/data/build-types/orders/types.d.ts node_modules/@woocommerce/data/build-types/payment-gateways/index.d.ts node_modules/@woocommerce/data/build-types/plugins/actions.d.ts node_modules/@woocommerce/data/build-types/plugins/index.d.ts node_modules/@woocommerce/data/build-types/product-attributes/types.d.ts node_modules/@woocommerce/data/build-types/product-shipping-classes/types.d.ts node_modules/@woocommerce/data/build-types/products/actions.d.ts node_modules/@woocommerce/data/build-types/products/types.d.ts node_modules/@woocommerce/data/build-types/user/types.d.ts node_modules/@woocommerce/data/typings/index.d.ts |
gigitux
changed the title
|
Size Change: -69 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
5 tasks
roykho
approved these changes
Oct 4, 2023
gigitux
deleted the
11103-product-hero-and-product-details-listing-block-patterns-run-a-query-on-every-page-load
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11103. Fix unnecessary queries on the front end side.
Why
The patterns are currently registered during the init action, which implies that these patterns are registered on the frontend. However, there is a problem with the current setup: two patterns perform a custom query each time a page is rendered on the frontend.
This pull request addresses this issue by transferring the logic responsible for fetching the product ID from PHP to JavaScript.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Product heroandProduct details listingpatterns.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog