This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery Thumbnails: Add View all overlay #11087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +256 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
danieldudzic
added
block: product gallery
danieldudzic
changed the title
woocommercebot
requested review from
a team and
nefeline
and removed request for
a team
This was referenced Oct 2, 2023
danieldudzic
changed the title
…ocks into fix/11083-product-gallery-thumbnails-add-view-all
|
Bumping this PR to the next release. |
… the View all overlay when in Dialog
…ew all thumbnails overlay even when the 'Full-screen when clicked' setting is disabled
gigitux
reviewed
Oct 10, 2023
assets/js/blocks/product-gallery/inner-blocks/product-gallery-large-image/frontend.tsx
Show resolved
Hide resolved
13 tasks
@roykho It seems that the failing test is trying to test the Sale Badge but gets tripped up by a second Sale Badge in the Dialog Product Gallery. This seems unrelated to my PR. Should I open a separate bug report? |
Interesting. The overlay is already in trunk. So I am wondering why it isn't failing tests there? |
The overlay? Sorry, I'm not sure I understand. This PR adds the 'View All' overlay. |
…g the first Sale Badge
…ttps://github.com/woocommerce/woocommerce-blocks into fix/11083-product-gallery-thumbnails-add-view-all
…ocks into fix/11083-product-gallery-thumbnails-add-view-all
roykho
approved these changes
Nov 1, 2023
danieldudzic
deleted the
fix/11083-product-gallery-thumbnails-add-view-all
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "View all" overlay to the last thumbnail which triggers the lightbox/dialog (which will display all the product gallery images).
What
Fixes #11083
Why
The "View all" overlay provides the user with feedback about the total number of available product images in the gallery (and offer a way to view them).
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Appearance > Editor.Templates > Single Product.Convert to Blocksif you are using the Classic Templates.Product Galleryblock.Number of Thumbnailssetting) and test the frontend. Make sure the last thumbnail displays an overlay that opens the Dialog on click.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog