This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: Password Protection not respected on single product template #10999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
force-pushed
the
10939-password-protection-not-respected-on-single-product-template
branch
from
c8844b8
to
25c5f23
Compare
…o 10939-password-protection-not-respected-on-single-product-template
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +55 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
danieldudzic
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Really, really solid work on this @gigitux! Tough problem, but I believe you have solved it very gracefully.
I was able to replicate the original issue with trunk and this PR indeed fixes it ✅
| * @internal | ||
| */ | ||
| class SingleProductTemplate { | ||
|
|
There was a problem hiding this comment.
Are two empty lines necessary?
Suggested change
gigitux
deleted the
10939-password-protection-not-respected-on-single-product-template
branch
tjcafferkey
reviewed
Sep 20, 2023
Comment on lines
+436
to
+437
| $new_content = SingleProductTemplateCompatibility::add_compatibility_layer( $template->content ); | ||
| $template->content = $new_content; |
There was a problem hiding this comment.
Could we not have just done:
$template->content = SingleProductTemplateCompatibility::add_compatibility_layer( $template->content );There was a problem hiding this comment.
True! I didn't change that code, but I just moved! Should I create a follow-up PR?
There was a problem hiding this comment.
I don't think it's urgent. I think I'll create a follow up for it later and you can review if that works 😃
|
Appreciate the tests that have come with this also @gigitux. Thank you! |
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #10939
Why
The function
add_password_formadds the password form to the single product template when the first block that belongs to the single product block is founded. The rest of the blocks related to the Single Product template are removed.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog