This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery: Lock the Sale Badge and the Next/Prev Buttons #10869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldudzic
added
the
type: enhancement
danieldudzic
added
the
block: product gallery
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +6 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
kmanijak
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
It works fine! Left one question, but pre-approving anyway!
Not related to this PR but let me leave a piece of feedback on Next/Prev Buttons.
I noticed the block offers horizontal alignment options that have no influence on the block, so potentially could be removed to avoid confusion.
Thanks! This is a known bug, and I have opened an issue for it in Gutenberg a while back: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #10868
Sale Badgestill allows the user to delete the block.Next/Prev Buttonssuch thing is not necessary as the user can hide the block with block settings.Why
This PR locks the
Sale BadgeandNext/Prev Buttonsblocks in order to prevent unexpected behavior when these blocks get moved.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Appearance > Editor.Templates > Single Product.Sale Badgebelow theNext/Prev Buttons.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog