This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 218
Dispatch the wc-blocks_render_blocks_frontend
event when rendering the empty cart block
#10619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
focus: blocks
Specific work involving or impacting how blocks behave.
block: cart
Issues related to the cart block.
labels
Aug 16, 2023
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
August 16, 2023 12:02
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +20 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
This was referenced Aug 16, 2023
wavvves
approved these changes
Aug 23, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Aug 23, 2023
kmanijak
pushed a commit
that referenced
this pull request
Aug 25, 2023
…the empty cart block (#10619)
imanish003
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com>
samueljseay
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com>
nefeline
added a commit
that referenced
this pull request
Aug 30, 2023
nefeline
added a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: cart
Issues related to the cart block.
focus: blocks
Specific work involving or impacting how blocks behave.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a condition to the
useEffect
inempty-cart-block/frontend.tsx
to check whether thewc-blocks_render_blocks_frontend
event should be dispatched.Currently this fires as soon as the whole Cart block is loaded, it seems like this is not correct as the inner blocks of the Empty Cart block should only render when it is visible.
Other Checks
[type]
label or a[skip-changelog]
label.Testing
Automated Tests
User-facing testing
Developer Facing Testing
wp-content/plugins/carousel-block/blocks/carousel/view.js
- change the code inside to:WooCommerce Visibility
Changelog