ECC key load: fixes #7751
Merged
ECC key load: fixes #7751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn.c: Return the curve OID sum with alg_id for ECC keys. ssl_load.c: Don't permanently strip the PKCS#8 information as it contains the curve OID.
dgarske
requested changes
Jul 22, 2024
| return ToTraditionalInline_ex2(input, inOutIdx, sz, algId, NULL); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Does this /* TODO: test case */ still apply? Can it be removed / confirmed that we do have test case?
There was a problem hiding this comment.
Called in falcon.c and sphincs.c.
We don't have tests calling the function directly.
dgarske
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
asn.c:
Return the curve OID sum with alg_id for ECC keys.
ssl_load.c:
Don't permanently strip the PKCS#8 information as it contains the curve OID.
Fixes zd#18272
Testing
./configure '--disable-shared' '--enable-ecccustcurves' '--disable-brainpool' 'CFLAGS=-DHAVE_ECC_KOBLITZ'
make test
Checklist