Fix TLS examples to not use openssl compatibility macros #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Apr 5, 2024
examples/tls/tls_client.c
Outdated
| @@ -48,6 +48,11 @@ | |||
| #include <wolfssl/certs_test.h> | |||
| #endif | |||
|
|
|||
| #ifdef OPENSSL_COEXIST | |||
| #undef SSL_SHUTDOWN_NOT_DONE | |||
| #define SSL_SHUTDOWN_NOT_DONE WOLFSSL_SHUTDOWN_NOT_DONE | |||
There was a problem hiding this comment.
No, just switch to using WOLFSSL_SHUTDOWN_NOT_DONE. None of this code is needed.
There was a problem hiding this comment.
Understood, fixed to a direct usage of WOLFSSL_SHUTDOWN_NOT_DONE instead of SSL_SHUTDOWN_NOT_DONE
night1rider
force-pushed
the
Coexist_TLS_Example
branch
from
b78f98e
to
b16a2b1
Compare
dgarske
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues building wolfSSL with provider or engine enabled.