Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for building with "-Wpedantic" #332

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Feb 29, 2024

Fixes for building with "-Wpedantic". Fix for C style comments. Fix for wolfSSL change with netdb.h.
ZD 17592

@dgarske dgarske self-assigned this Feb 29, 2024
@dgarske
Copy link
Contributor Author

dgarske commented Feb 29, 2024

Seems like the compiler for GitHub actions is defaulting to C99 now? Working on a fix.

@dgarske
Copy link
Contributor Author

dgarske commented Feb 29, 2024

Seems like the compiler for GitHub actions is defaulting to C99 now? Working on a fix.

The error is due to a wolfSSL PR : wolfSSL/wolfssl#7072 . Investigating.

@dgarske dgarske force-pushed the pedantic branch 2 times, most recently from 7b5dcaf to 8c4caff Compare February 29, 2024 17:33
…sure `netdb.h` is included. Previously wolfSSL always included netdb.h, but now it requires `HAVE_NETDB_H`.
Copy link
Contributor

@bandi13 bandi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@douzzer douzzer merged commit 1618411 into wolfSSL:master Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants