Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for using endorsement hierarchy #320

Merged
merged 5 commits into from
Dec 29, 2023

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Dec 28, 2023

  • Fixes for attestation with endorsement key.
  • Enable the broken endorsement tests.
  • Fix native test TPM2_PolicyPCR.
  • Remove the WOLFTPM2_KEYBLOB.name (deprecated) and is in handle.name now.
  • Improve TPM2_GetRCString error rendering to correctly resolve RC_WARN. Add parameter, session and handle debug information. Refactor line length / alignment. Remove duplicate "success".
  • Fix CMake build broken since cryptocb refactor in PR Relocate crypto callback code to its own code file #304.
  • Added CI tests for CMake.

Fixes #282

@dgarske dgarske self-assigned this Dec 28, 2023
@embhorn
Copy link
Member

embhorn commented Dec 29, 2023

cmake build error:

[ 21%] Linking C executable bin/activate_credential
/usr/bin/ld: libwolftpm.so: undefined reference to `wolfTPM2_CryptoDevCb'
/usr/bin/ld: libwolftpm.so: undefined reference to `wolfTPM2_ClearCryptoDevCb'
collect2: error: ld returned 1 exit status
gmake[2]: *** [CMakeFiles/activate_credential.dir/build.make:99: bin/activate_credential] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:192: CMakeFiles/activate_credential.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2

Copy link
Member

@embhorn embhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with RPi / Infineon TPM

Fix spelling issue and review cmake error

Copy link
Member

@embhorn embhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@embhorn embhorn merged commit e9ca868 into wolfSSL:master Dec 29, 2023
3 checks passed
@dgarske dgarske deleted the fix_endorsement branch January 26, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keygen -rsa -eh failed with TPM_RC_BAD_AUTH
2 participants