Added tests for keyblob buffer export/import and support for getting sizes #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embhorn
requested changes
Dec 8, 2023
src/tpm2_wrap.c
Outdated
| return BUFFER_E; | ||
| } | ||
| sz = 0; | ||
|
|
||
| /* Write size marker for the public part */ | ||
| XMEMCPY(buffer + sz, &key->pub.size, sizeof(key->pub.size)); |
There was a problem hiding this comment.
+ sz can be removed here since its always zero now.
src/tpm2_wrap.c
Outdated
| TPM2_PrintBin(privBuffer, *privBufferSz); | ||
| printf("Getting %d bytes for private buffer\n", (int)*privBufferSz); | ||
| #endif | ||
|
|
||
| return sz; |
There was a problem hiding this comment.
sz never changes. Could remove it and just return success here.
wolftpm/tpm2_wrap.h
Outdated
| @@ -3168,11 +3168,13 @@ WOLFTPM_API int wolfTPM2_GetKeyBlobAsBuffer(byte *buffer, word32 bufferSz, | |||
|
|
|||
| \brief Marshal data from a keyblob to a binary buffer. This can be | |||
| stored to disk for loading in a separate process or after power | |||
| cycling. | |||
| cycling. If either buffer is NULL then the size will be returned for | |||
| each part. | |||
|
|
|||
| \return Positive integer (size of the output) | |||
embhorn
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for getting the keyblob sizes. ZD 16675