-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for importing and loading public ECC/RSA keys formatted as PEM or DER #290
Conversation
7bf4bb1
to
da9f3fb
Compare
da9f3fb
to
1faa845
Compare
1faa845
to
6126d04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test requires CFLAGS='-DWOLFSSL_PUBLIC_MP' for wolfSSL right? should add
#if !defined(WOLFTPM2_NO_WRAPPER) && !defined(WOLFTPM2_NO_WOLFCRYPT) && defined(WOLFSSL_PUBLIC_MP)
to main, couldn't tag it in the review
Yes and that change has been upstreamed into wolfSSL master with --enable-wolftpm. The |
No I'm saying to give the user the not compiled in error if their wolfSSL is compiled wrong, like this:
but add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with known bad wolfssl build, rsa woked correctly and ecc correctly printed the not compiled in error
No description provided.