-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding STM32 Expansion Pack #287
Conversation
IDE/STM32CUBE/wolftpm_test.c
Outdated
printf("Running wolfTPM Tests...\n"); | ||
|
||
/* Run wolfTPM unit tests */ | ||
if (unit_tests(0, NULL)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer the wrap_test, not the unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
IDE/STM32CUBE/default_conf.ftl
Outdated
|
||
#undef USE_HW_SPI_CS | ||
#if defined(WOLFTPM_CONF_HW_SPI) && WOLFTPM_CONF_HW_SPI == 1 | ||
#define USE_HW_SPI_CS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 4 spaces, not tabs (also above). What is USE_HW_SPI_CS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. It guards the calls to GPIO_WRITE_PIN()
. I thought it would be something users want to toggle based off the OPENSTM32 user_setting.h
IDE/STM32CUBE/wolftpm_test.h
Outdated
#include <config.h> | ||
#endif | ||
|
||
int TPM2_Wrapper_Test(void* userCtx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can come from examples/wrap/wrap_test.h or just put in the .c file and use extern int TPM2_Wrapper_Test(void* userCtx);
.
IDE/STM32CUBE/wolftpm_test.h
Outdated
@@ -0,0 +1,40 @@ | |||
/* wolfssh_test.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wolftpm_test.h
IDE/STM32CUBE/wolftpm_test.c
Outdated
#endif | ||
{ | ||
int ret = 0; | ||
#if 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this. The TPM2_WolfCrypt_Init
already has DEBUG_WOLFSSL and this call.
No description provided.