Fixes for TPM private key import with custom seed #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtPrivateKeyBuffer` for importing private key ECC/RSA in either PEM or DER(ASN.1). ZD16249
jpbland1
reviewed
Jul 20, 2023
src/tpm2_wrap.c
Outdated
| #else | ||
| (void)dev; | ||
| (void)in; | ||
| (void)salt; | ||
| rc = NOT_COMPILED_IN; |
There was a problem hiding this comment.
wolfTPM2_EncryptSalt is always returning NOT_COMPILED_IN, I think this rc = NOT_COMPILED_IN is from the old code and you just missed deleting this line
There was a problem hiding this comment.
actually now that I look at it why was that else macro removed? if WOLFTPM2_NO_WOLFCRYPT is defined rc will be undefined before return, you could probably change it to int rc = NOT_COMPILED_IN; at the start of the function
jpbland1
requested changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfTPM2_ImportPrivateKeyBufferfor importing private key ECC/RSA in either PEM or DER(ASN.1).ZD 16249