Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add thread local storage macro and make gActiveTPM local to the thread #253

Merged
merged 3 commits into from
Jan 17, 2023
Merged

add thread local storage macro and make gActiveTPM local to the thread #253

merged 3 commits into from
Jan 17, 2023

Conversation

jpbland1
Copy link
Contributor

in response to #247

@jpbland1 jpbland1 requested a review from dgarske January 16, 2023 20:38
@jpbland1
Copy link
Contributor Author

https://gist.github.com/jpbland1/f3eeb83c0d413152281e5058246d3e55 gist that tests the thread seperation

@jpbland1 jpbland1 marked this pull request as ready for review January 16, 2023 20:54
@dgarske dgarske self-assigned this Jan 16, 2023
dgarske
dgarske requested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works. See if you can add the test case to the tests/unit_tests.c. You'll have to add some pthread checks. Just model from the wolfSSL checks.

@dgarske dgarske merged commit 94a4c8f into wolfSSL:master Jan 17, 2023
@jpbland1 jpbland1 mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarske dgarske dgarske approved these changes

Assignees

@dgarske dgarske

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbland1 @dgarske