Fix for CSharp SetCustomExtension
#239
Conversation
wolftpm/tpm2_wrap.h
Outdated
| defined(HAVE_OID_ENCODING) | ||
|
|
||
| #ifndef WOLFTPM2_NUM_CUSTOM_EXT | ||
| #define WOLFTPM2_NUM_CUSTOM_EXT 16 |
There was a problem hiding this comment.
Can’t we get the defaults from wolfCrypt?
wolftpm/tpm2_wrap.h
Outdated
| typedef struct WOLFTPM2_CSR { | ||
| #if defined(WOLFSSL_ASN_TEMPLATE) && defined(WOLFSSL_CUSTOM_OID) && \ |
There was a problem hiding this comment.
I prefer these defines to be outside the typedef although I realize it works this way too.
wrapper/CSharp/wolfTPM-tests.cs
Outdated
| @@ -540,6 +540,8 @@ public void TryGenerateCSRCustomOID() | |||
| Assert.That(rc, Is.GreaterThan(0)); | |||
|
|
|||
| Console.WriteLine("CSR PEM {0} bytes", rc.ToString()); | |||
| var writer = new BinaryWriter(File.OpenWrite("csr.pem")); | |||
There was a problem hiding this comment.
This could be handy. Any issue running it over and over?
There was a problem hiding this comment.
Glad you like it.!
If you used over and over then it would probably write all the things to the same file? I would think the writer needs to fall out of scope and then the garbage collector would then close the file?
I can break this out to its own function. Then it could fall out of scope and it would make things clearer.
|
Please do not merge. Still waiting for customer feedback. |
dgarske
changed the title
SetCustomExtension
|
I have tested @dgarske 's lastest change. It works as expected and I approve. |
|
Going to go ahead and merge. I believe this fix solves things for the customer. |
Tested with the CSharp wrapper tests and inspected the CSR.
Fixes ZD14713