Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSharp support for setting the auth on a key blob #237

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Add CSharp support for setting the auth on a key blob #237

merged 1 commit into from
Aug 11, 2022

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Aug 10, 2022

  • Adds SetKeyAuthPassword for KeyBlob.
  • Adds missing test case.
    ZD 14633

@dgarske dgarske self-assigned this Aug 10, 2022
@dgarske dgarske requested a review from anhu August 10, 2022 15:23
anhu
anhu approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@anhu anhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and fixup!!

I think it is weird that it will only return success. Perhaps this should just be void, but that would break a pattern in the API so this is fine.

@dgarske dgarske assigned anhu and unassigned dgarske Aug 11, 2022
@anhu anhu merged commit 7308083 into wolfSSL:master Aug 11, 2022
@dgarske dgarske deleted the csharp_setauth branch September 1, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhu anhu anhu approved these changes

Assignees

@anhu anhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgarske @anhu