Added CSharp wrapper support for RSA encrypt/decrypt and Sign/Verify #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgarske
commented
Jul 21, 2022
dgarske
commented
- Fixed issue with sign signature buffer size checking.
- Changed wrapper algorithm arguments to use enum TPM2_Alg.
… Fixed issue with sign signature buffer size checking. Changed wrapper algorithm arguments to use enum TPM2_Alg.
…ting doxygen from tpm2_wrap.h to inline CSharp function documentation format.
anhu
requested changes
Jul 22, 2022
| XMEMCPY(sig + signOut.signature.signature.ecdsa.signatureR.size, | ||
| signOut.signature.signature.ecdsa.signatureS.buffer, | ||
| signOut.signature.signature.ecdsa.signatureS.size); | ||
| sigOutSz = signOut.signature.signature.ecdsa.signatureR.size + |
There was a problem hiding this comment.
Should there be a check here that R and S sizes are equal? You assume so below during the memcpy()
…R_Generate_ex` and possible use of uninitialized `csrKey->keyType` on cleanup.
anhu
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.