Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for c++ compiler #206

Merged
merged 2 commits into from
May 6, 2022
Merged

Fixes for c++ compiler #206

merged 2 commits into from
May 6, 2022

Conversation

elms
Copy link

@elms elms commented May 6, 2022 •
edited
Loading

  • remove use of reserved c++ keyword template
  • remove use of struct designator initialization (sort of supported in c++20, but easier to just remove)

@elms elms requested a review from anhu May 6, 2022 16:36
@elms elms assigned anhu May 6, 2022
@anhu anhu assigned elms and unassigned anhu May 6, 2022
@elms elms assigned anhu May 6, 2022
@anhu anhu merged commit d22a050 into wolfSSL:master May 6, 2022
@elms elms deleted the fix/c++ branch May 6, 2022 17:24
SparkiDev
SparkiDev reviewed May 8, 2022
View reviewed changes
src/tpm2_wrap.c
@@ -224,22 +224,22 @@ int wolfTPM2_FreeKeyBlob(WOLFTPM2_KEYBLOB* blob)

TPMT_PUBLIC* wolfTPM2_NewPublicTemplate(void)
{
TPMT_PUBLIC* template = NULL;
TPMT_PUBLIC* PublicTemplate = NULL;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PublicTemplate -> publicTemplate

@dgarske dgarske mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SparkiDev SparkiDev SparkiDev left review comments

@anhu anhu anhu approved these changes

Assignees

@anhu anhu

@elms elms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elms @anhu @SparkiDev