Fix incorrect message and HTTP status code when no instance is available #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug has been around for at least 19 years, as described on [this thread](https://webobjects-dev.omnigroup.narkive.com/7gWK5EfH/http-500-error-a-nightmare). The WebObjects adaptor may return an incorrect HTTP status code and message when no instance of an application is available to handle the request. It's fairly easy to reproduce the problem: 1. Set up a WebObjects application with a single instance. 2. Try to access the application from a browser with the instance stopped. ``` GET - /cgi-bin/WebObjects/my-app.woa/wa/default Status: 500 Message: No instance available ``` 3. Reload the browser, and you'll get a different response. ``` GET - /cgi-bin/WebObjects/my-app.woa/wa/default Status: 404 Message: The requested application was not found on this server ``` When no instance is available, returning a 404 status code is problematic, especially if the URL being accessed is part of a REST API. This fix will ensure that the WebObjects adaptor will return the correct HTTP status code and message for every request when no instance is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has been around for at least 19 years, as described on this thread. The WebObjects adaptor may return an incorrect HTTP status code and message when no instance of an application is available to handle the request. It's fairly easy to reproduce the problem:
When no instance is available, returning a 404 status code is problematic, especially if the URL being accessed is part of a REST API. This fix will ensure that the WebObjects adaptor will return the correct HTTP status code and message for every request when no instance is available.