Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper method to create an aggregate function for string #964

Merged

Conversation

spelletier
Copy link
Member

in ERXEOControlUtilities.

@paulhoadley paulhoadley self-requested a review January 7, 2022 07:00
Copy link
Contributor

@paulhoadley paulhoadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading this correctly, it's a cover method for _aggregateFunctionWithQualifier() where you supply String.class to that method, and then cast the result to a String?

@hprange
Copy link
Contributor

hprange commented Jan 8, 2022

It seems so. What bothers me about this pull request is the Javadoc.

select MAX(AGE) from User where name like 'M*'

This query doesn't seem like a good example of when to use this method. @spelletier what's your use case? Can we improve the Javadoc to reflect it?

@spelletier
Copy link
Member Author

@paulhoadley, this is a simple wrapper indeed. @hprange, I adjusted the javadoc with a real usage.

@hprange hprange merged commit a09321c into wocommunity:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants