Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to customize Java date/time formats while coercing values on ERRest requests #963

Merged

Conversation

hprange
Copy link
Contributor

@hprange hprange commented Nov 15, 2021

This change adds three properties to help customize the format of Java date/time values:

  • er.rest.javaFormatDate
  • er.rest.javaFormatDateTime
  • er.rest.javaFormatTime

It also includes three properties to provide a DateTimeFormatter to parse/format Java date/time values:

  • er.rest.javaDateFormatter
  • er.rest.javaDateTimeFormatter
  • er.rest.javaTimeFormatter

I didn't add the "spaces" workaround intentionally since this is a new implementation, and it doesn't make sense in all cases. Please, let me know if you need it.

…lues on ERRest requests

This change adds three properties to help customize the format of Java date/time values:

- er.rest.javaFormatDate
- er.rest.javaFormatDateTime
- er.rest.javaFormatTime

It also includes three properties to provide a `DateTimeFormatter` to parse/format Java date/time values:

- er.rest.javaDateFormatter
- er.rest.javaDateTimeFormatter
- er.rest.javaTimeFormatter

I didn't add the "spaces" workaround intentionally since this is a new implementation, and it doesn't make sense in all cases. Please, let me know if you need it.
@hprange hprange self-assigned this Nov 15, 2021
@hprange

This comment has been minimized.

@paulhoadley paulhoadley self-requested a review January 7, 2022 01:45
Copy link
Contributor

@paulhoadley paulhoadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@darkv darkv merged commit 2e1c189 into wocommunity:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants