Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERXPropertyListSerialization goes utf8 #959

Merged
merged 3 commits into from
Jan 16, 2022
Merged

ERXPropertyListSerialization goes utf8 #959

merged 3 commits into from
Jan 16, 2022

Conversation

renebock
Copy link
Contributor

This pullrequest Prevent quoting UTF-8 (non ASCII) characters in method stringFromPropertyList.

This is necessary when you have to relay on

stringFromPropertyList(propertyListFromString(plistContainingUtf8Chars)).equals(plistContainingUtf8Chars)

e.g in a Plist-Text-Editor.

@hprange hprange changed the title ERXPopertyListSerialization goes utf8 ERXPropertyListSerialization goes utf8 Jan 16, 2022
hprange
hprange approved these changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@hprange hprange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm not sure how to test it thoroughly. Anyway, it works with simple inputs.

@hprange hprange merged commit 10da698 into wocommunity:master Jan 16, 2022
@sal-bock sal-bock deleted the ERXPropertyListSerialization-UTF8 branch March 14, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hprange hprange hprange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renebock @hprange