Fix NullPointerException when calling the EOModel.createPrototypeCache method from the wrong EOModel (take 2) #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e method from the wrong EOModel (take 2) This error was first reported and fixed by the PR wocommunity#551. One reason for this kind of error is the presence of duplicate `NSBundles` in the classpath. The previous fix prevented EOModels from the same `NSBundle` from being loaded twice. There's another scenario, though, where the same issue may arise. If two distinct `NSBundle`s have the same EOModel, the application may not initialize properly, throwing the exception below: ``` java.lang.NullPointerException at com.webobjects.eoaccess.EOModel.createPrototypeCache(EOModel.java:631) at com.webobjects.eoaccess.EOModel.prototypeAttributeNamed(EOModel.java:699) at com.webobjects.eoaccess.ERXModel.prototypeAttributeNamed(ERXModel.java:290) at com.webobjects.eoaccess.EOAttribute.<init>(EOAttribute.java:998) ``` This fix prevents EOModels with the same name from being loaded twice.
|
I cherry-picked this change into the |
paulhoadley
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error was first reported and fixed by the PR #551. One reason for this kind of error is the presence of duplicate
NSBundles in the classpath. The previous fix prevented EOModels from the sameNSBundlefrom being loaded twice.There's another scenario, though, where the same issue may arise. If two distinct
NSBundles have the same EOModel, the application may not initialize properly, throwing the exception below:This fix prevents EOModels with the same name from being loaded twice.