Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERXConfigurationManager isDeployedAsServlet relies now on the configu… #956

Closed
wants to merge 2 commits into from

Conversation

renebock
Copy link
Contributor

…red WOContext class rather on a check, if the JavaWOJSPServlet framework is loaded

(Now without the ERXProperties Changes)

…red WOContext class rather on a check, if the JavaWOJSPServlet framework is loaded
@renebock
Copy link
Contributor Author

This pull requests fixes #951

@paulhoadley paulhoadley self-requested a review January 7, 2022 06:51
Copy link
Contributor

@paulhoadley paulhoadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but where are the new contextClassName() and setContextClassName() methods being called?

@renebock
Copy link
Contributor Author

renebock commented Jan 7, 2022

setContextClassName is used by contextClassName for lazy initialialization, contextClassName is used by isDeployedAsServlet.

The methods may be marked as private.

@paulhoadley
Copy link
Contributor

Ah thanks @renebock, I was assuming there was some external usage.

@paulhoadley
Copy link
Contributor

I've made some trivial changes and re-submitted this work as #970, which I'll merge shortly. Thanks @renebock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants