Add null check to observeField() function #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some user interface components switch between view only and editing mode. When in view mode the form fields are left out of the page. This results in javascript errors when having AjaxObserveField when the observe element does not exist. Rather than putting a WOConditional around every AjaxObserveField it seems better to simply add a null check in the observeField() function used by AjaxObserveField. This simplifies things.
The fix adds a null check at the top and logs a message to the javascript console if the element does not exist rather than resulting in javascript errors which looks pretty bad.