Nullify handling for toMany relationships. #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toMany relationships should always have an empty array. There was a bug here where we set that array to null which will surprise people. People expecting to have an empty array will have a null pointer instead without this fix. Signed-off-by: Aaron Rosenzweig <aaron@chatnbike.com>
|
Is this going to be merged? I've been using it with great success. Thanks! |
|
There you go :) |
|
Thank you Johann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toMany relationships should always have an empty array. There was a bug here where we set that array to null which will surprise people. People expecting to have an empty array will have a null pointer instead without this fix.
Note: It is important to set a Mutable array because that's what it is internally even though the Apple/NeXT API shows immutable getters. If you think about it, this makes sense. They don't want you adding/remove directly from the array but internally the data structure needs to be mutable.
Signed-off-by: Aaron Rosenzweig aaron@chatnbike.com