Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERAttachment name with currency error #941

Merged

Conversation

luizalfredo23
Copy link
Contributor

@luizalfredo23 luizalfredo23 commented Mar 1, 2021

While uploading files with a currency symbol, an error s of Illegal group reference was happening.

I had to escape this symbol on each regex evaluation.

@luizalfredo23 luizalfredo23 changed the title ErAttachment name with currency error ERAttachment name with currency error Mar 2, 2021
@hprange hprange added the Wonder7 label Aug 6, 2021
@hprange
Copy link
Contributor

hprange commented Jan 16, 2022

Luiz has been using this change in production for quite some time. It seems safe to merge it.

@hprange hprange merged commit 22d5df0 into wocommunity:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants