Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for X-HTTP-Method-Override header on REST requests #814

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Add support for X-HTTP-Method-Override header on REST requests #814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Frameworks/EOF/ERRest/Sources/er/rest/routes/ERXRouteRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,11 @@
* @author mschrag
*/
public class ERXRouteRequestHandler extends WODirectActionRequestHandler {
/**
* Header used to override the method of a request. Useful when client code can use only GET and POST methods.
*/
private static final String X_HTTP_METHOD_OVERRIDE_HEADER_KEY = "x-http-method-override";

/**
* A NameFormat that behaves like Rails -- plural entities, plural routes, lowercase underscore names
* (names_like_this).
Expand Down Expand Up @@ -823,8 +828,9 @@ public NSArray getRequestHandlerPathForRequest(WORequest request) {

try {
String path = request._uriDecomposed().requestHandlerPath();
String method = request.headerForKey(X_HTTP_METHOD_OVERRIDE_HEADER_KEY, request.method());

ERXRoute matchingRoute = setupRequestWithRouteForMethodAndPath(request, request.method(), path);
ERXRoute matchingRoute = setupRequestWithRouteForMethodAndPath(request, method, path);
if (matchingRoute != null) {
@SuppressWarnings("unchecked")
NSDictionary<ERXRoute.Key, String> keys = (NSDictionary<ERXRoute.Key, String>) request.userInfo().objectForKey(ERXRouteRequestHandler.KeysKey);
Expand Down