Small patches for er.extensions.appserver.navigation #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code has been in production for two years or so and seems to work. It simply checks the current request and finds out whether it is secure returning a URL that honours the current status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark Wardle supplied a couple of patches via the mailing list:
ERXNavigationItem.java.ERXNavigationMenuItem.javais secure if the current request is secure.I don't use
ERXNavigationMenuItem.java, so I can't really vouch for the latter patch, though it looks legit at a glance. Ideally someone that uses this package could check it out, though I imagine Mark's got the class in use and that this change works just fine.