Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ERXPartialInitializer handle locking and class property settings correctly #804

Merged

Conversation

fbarthez
Copy link
Contributor

For partial entities, fix handling of the "locking" setting on attributes and the "class property" setting on attributes and relationships.

Add reminders for missing functionality to deal with user info data.

…utes and the "class property" setting on attributes and relationships.

Add reminders for missing functionality to deal with user info data.
@paulhoadley
Copy link
Contributor

Hi Fabian,

Thanks for this. Could you tell me a little more about the problem this is solving? Was it just that those characteristics of properties weren't being merged at all?

(Not doubting your fix, it's just that we use partials quite extensively, so I keep a keen eye on changes.)

@fbarthez
Copy link
Contributor Author

Hi Paul, the problem is that on adding a new EOAttribute, it'll always be added to the list of attributes used for locking and to the list of class properties (ignoring some special cases like derived and flattened). So the fix makes sure that your choices regarding these settings are applied to the partial entity.

@darkv
Copy link
Member

darkv commented Nov 25, 2016

@paulhoadley can we merge this?

@paulhoadley
Copy link
Contributor

Sorry guys, I neglected to follow this through. I'm sure we can. I'll get on it this weekend.

@paulhoadley paulhoadley self-assigned this Nov 25, 2016
@paulhoadley paulhoadley merged commit 5a7d1d9 into wocommunity:master Nov 27, 2016
@fbarthez fbarthez deleted the pr/ERXPartials-attributePropertiesFix branch March 8, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants