Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ERMODEditableListTemplate for editing all items in a list #803

Merged

Conversation

fbarthez
Copy link
Contributor

ERMODEditableListTemplate works both at page-level and as an embedded component. Unlike its superclass it'll handle changes to the batch size, by wrapping the list in an AjaxObserveField.

Known issues:

  • fields in the list will get duplicate IDs
  • validation handling is entirely untested

…th at page-level and as an embedded component. Unlike its superclass it'll handle changes to the batch size, by wrapping the list in an AjaxObserveField.

Known issues:
* fields in the list _will_ get duplicate IDs
* validation handling is entirely untested
Copy link
Contributor

@hprange hprange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I didn't test it. I would merge it anyway.

@hprange hprange merged commit 0b46666 into wocommunity:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants