Correct validation if values are coerced #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes the situation where you have validation rules at multiple places where coerced values could have been lost or the wrong values validated
darkv
referenced
this pull request
Aug 5, 2016
do not throw away return value of _validateValueForKey that is used e.g. in ERXPartialGenericRecord
|
Looks good to me Johann. I'll merge it tomorrow if there's no further input from anyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are coercing values in your validation methods these value changes could get lost or based on wrong values in some edge cases.
There are three main locations for key related validation:
Point 3 could theoretically contain multiple partials even though this should be quite unusual. During 1. and 3. the validated value can be coerced though some of the methods did get the original value instead of the coerced one. This is inconsistent and can lead to data loss which this patch fixes.