Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents ERXTimeZoneDetector calling setTimeZone() with null argument #775

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Prevents ERXTimeZoneDetector calling setTimeZone() with null argument #775

merged 1 commit into from
Jun 27, 2016

Conversation

paulhoadley
Copy link
Contributor

As discussed in #774, ERXTimeZoneDetector will call ERXSession.setTimeZone() with a null argument if it can't find a timezone, causing an NPE. Here we just add a check for null, and log a warning (and do nothing else) if found.

@darkv darkv merged commit fb64e2a into wocommunity:master Jun 27, 2016
@darkv
Copy link
Member

darkv commented Jun 27, 2016

Thanks :)

@paulhoadley paulhoadley mentioned this pull request Jun 27, 2016
Closed
@paulhoadley paulhoadley deleted the null-timezone-fix branch July 14, 2016 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Wonder7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulhoadley @darkv