Adds proxy binding for AjaxProxy component #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the proxy binding is not set, AjaxProxy uses its containing component (so, in this case, the AjaxFlexibleFileUpload component) as its server-side proxy object. This exposes all public methods of that component to the client-side Javascript object. At that point, a malicious user can fairly easily call some significant methods, such as Application.terminate() to shut down the application instance. Here we add a single-purpose Proxy object as an inner class of AjaxFlexibleFileUpload which simply wraps the methods that we need to call from the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a single-purpose
Proxyobject as an inner class ofAjaxFlexibleFileUploadwhich simply wraps the methods that we need to call from the client. Fixes the security issue described in #768.