Add character encoding to REST responses #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkv
added a commit
that referenced
this pull request
Jan 14, 2016
Add character encoding to REST responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a default character encoding that can be overridden to ERXRestWriter classes. By this the HTTP header Content-Type of the response will be set accordingly making it possible for a client to detect the correct encoding. This encoding information will be passed on to the WOResponse object too so that correct handling of the response content is possible.
For Wonder6 this patch will force users to implement the
IERXRestResponse.setContentEncoding(String)method in own classes as including a default interface implementation works only in Java 8.