Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for ERProfiling #662

Merged
merged 3 commits into from
Jul 22, 2015

Conversation

darkv
Copy link
Member

@darkv darkv commented Jul 22, 2015

This patch include several enhancements for ERProfiling:

  • the doctype tag and any HTML comments won't get a class attribute anymore (future enhancement could be to exclude all tags that don't allow a class attribute)
  • use CSS outline instead of border in order to not "destroy" your HTML layout as border will change either dimensions of element (box-sizing: content-box) or content (box-sizing: border-box)
  • check if a tag already has a class attribute (former implementation looked up only first attribute, leading to tags with two class attributes which is not allowed and will formally delete the second one thus removing CSS classes you probably need…)

darkv added a commit that referenced this pull request Jul 22, 2015
@darkv darkv merged commit 0f57e65 into wocommunity:master Jul 22, 2015
@darkv darkv deleted the erprofiling_enhancements branch July 22, 2015 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant