fix default submit button for IE #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkv
added a commit
that referenced
this pull request
Jun 29, 2015
fix default submit button for IE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Internet Explorer the default submit button from ERXWOForm does not work, hitting return from within a form input does not submit the form. That browser seems to ignore elements that have either the attribute display:none or visibility:hidden. A fix is to remove those attributes for the default submit button. As the element has an absolute position it does not interfere with the text flow and thus won't break layout.
This has been successfully tested with IE9, IE10, Safari 7, Firefox 10, Firefox 38, Chrome 43.